Fix useless-cast warning #1090
Closed
Fix useless-cast warning #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 57 57
Lines 5991 5991
=======================================
Hits 5022 5022
Misses 969 969 ☔ View full report in Codecov by Sentry. |
graebm
reviewed
Feb 13, 2024
include/aws/common/math.inl
Outdated
| @@ -53,6 +53,13 @@ AWS_EXTERN_C_BEGIN | |||
| # pragma warning(disable : 4127) /*Disable "conditional expression is constant" */ | |||
| #endif /* _MSC_VER */ | |||
|
|
|||
| #ifdef __cplusplus | |||
| # if defined(__GNUC__) | |||
| # pragma GCC diagnostic push | |||
There was a problem hiding this comment.
You also need to pop
Otherwise, any code that includes the .h file that includes this .inl file will have these warnings disabled
|
Fixed it here: #1145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#973
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.