Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best Effort Thread Pinning to CPU_ID #1096

Merged
merged 28 commits into from
Mar 15, 2024
Merged

Best Effort Thread Pinning to CPU_ID #1096

merged 28 commits into from
Mar 15, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Mar 8, 2024

Description of changes:
Sometimes, pthread_create can fail with an EINVAL error, or on FreeBSD, it can fail with an EDEADLK error if the cpu_id is restricted. Since pinning to a particular cpu_id is supposed to be best-effort, try to launch a thread again without pinning to a specific cpu_id.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (4e1cfca) to head (c89be7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
+ Coverage   83.04%   83.15%   +0.11%     
==========================================
  Files          56       56              
  Lines        5762     5765       +3     
==========================================
+ Hits         4785     4794       +9     
+ Misses        977      971       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 marked this pull request as draft March 8, 2024 21:01
@waahm7 waahm7 marked this pull request as ready for review March 11, 2024 18:00
@waahm7 waahm7 merged commit 71c6ab7 into main Mar 15, 2024
52 checks passed
@waahm7 waahm7 deleted the best_effort_pthread_create branch March 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants