Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test skipping #1118

Merged
merged 3 commits into from
May 30, 2024
Merged

Fix test skipping #1118

merged 3 commits into from
May 30, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented May 29, 2024

Issue:

The SKIP code worked in aws-crt-cpp's tests, not in any aws-c-* tests

Description of changes:

  • Set SKIP_RETURN_CODE in CMake script that generates C test runner (the CPP script had it, but not the C script)
  • Skip leak checks when a test is skipped
    • this keeps the tests simple, you can bail out in the middle without cleaning up

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (ce899b9) to head (1b28e99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files          56       56           
  Lines        5754     5754           
=======================================
  Hits         4783     4783           
  Misses        971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graebm graebm merged commit dae0e52 into main May 30, 2024
52 checks passed
@graebm graebm deleted the fix-test-skipping branch May 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants