Fix out variable in cmake sanitizer module #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The
aws_check_sanitizer
cmake function incorrectly handles the out parameter. The issue is withif(NOT ${ARGN})
check.When an extra parameter is passed to the function (e.g.,
aws_check_sanitizer("thread" CUSTOM_OUT_VAR)
),if(NOT ${ARGN})
checks the value of this extra parameter. This means that${CUSTOM_OUT_VAR}
will be used as out variable only if it's undefined/false:When no extra parameter is passed (e.g.,
aws_check_sanitizer("thread")
), this check essentially transforms toif(NOT)
. Which looks kind of weird, but in practice works fine.Description of changes:
Check for the number of passed parameter to determine which variable to use as out parameter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.