Update CMake to 3.9 #1159
Merged
Update CMake to 3.9 #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at backtraces show more function names
I don't have time right now to investigate the impact of this change
Use latest versions of proof tools
Co-authored-by: Michael Graeb <graebm@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 83.84% 83.62% -0.23%
==========================================
Files 57 57
Lines 5992 5947 -45
==========================================
- Hits 5024 4973 -51
- Misses 968 974 +6 ☔ View full report in Codecov by Sentry. |
graebm
approved these changes
Oct 22, 2024
cmake/AwsCFlags.cmake
Outdated
| @@ -231,7 +231,6 @@ function(aws_set_common_properties target) | |||
|
|
|||
| # try to check whether compiler supports LTO/IPO | |||
| if (POLICY CMP0069) | |||
There was a problem hiding this comment.
I know we're not trying to rewrite the world, but since this touches a POLICY ... we can replace this if (POLICY CMP0069) block with simpler code
# check whether compiler supports LTO/IPO
include(CheckIPOSupported)
check_ipo_supported(RESULT ipo_supported)
if (ipo_supported)
message(STATUS "Enabling IPO/LTO for Release builds")
else()
message(STATUS "AWS_ENABLE_LTO is enabled, but cmake/compiler does not support it, disabling")
set(_ENABLE_LTO_EXPR OFF)
endif()
| @@ -1,17 +1,13 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| # SPDX-License-Identifier: Apache-2.0. | |||
|
|
|||
| cmake_minimum_required(VERSION 3.0) | |||
| cmake_minimum_required(VERSION 3.9) | |||
There was a problem hiding this comment.
Add comment about WHY we're picking CMake 3.9. Because it's the latest supported version in ... RHEL5? Amazon Linux 1?
This was referenced Oct 23, 2024
This was referenced Oct 23, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
-fvisibility=hiddenwhen building a static library. #1142Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.