Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift CXX Interop #1160

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Support Swift CXX Interop #1160

merged 2 commits into from
Oct 21, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Oct 18, 2024

Issue #, if available:
awslabs/aws-crt-swift#166

Description of changes:

  • Don't include inl files as part of extern C. We use AWS_EXTERN_C_BEGIN and AWS_EXTERN_C_END within the inl files.
  • Ideally, we should add CI in common as well, but I don't know how. I will add CI in crt-swift.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (f58e807) to head (220324f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files          57       57           
  Lines        5992     5992           
=======================================
  Hits         5024     5024           
  Misses        968      968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit faa6c0f into main Oct 21, 2024
53 checks passed
@waahm7 waahm7 deleted the cxx-interop-support branch October 21, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants