correct the doc about unactivated stream and add test #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
approved these changes
Dec 21, 2023
| @@ -188,13 +188,14 @@ typedef int(aws_http_on_incoming_request_done_fn)(struct aws_http_stream *stream | |||
| /** | |||
| * Invoked when request/response stream is completely destroyed. | |||
| * This may be invoked synchronously when aws_http_stream_release() is called. | |||
| * This is invoked even if the stream is never activated. | |||
| * This will not be invoked if the stream is never activated. | |||
There was a problem hiding this comment.
if we don't invoke it on unactivated streams, is the the line above still true?
This may be invoked synchronously when aws_http_stream_release() is called.
There was a problem hiding this comment.
I was wondering how this comment ever got here. Looks like I suggested it for the destroy_fn when the destroy_fn was added to the API, but you accidentally added it to the complete_fn instead.
#390 (comment)
There was a problem hiding this comment.
The docs for aws_http_on_stream_complete_fn should go back to what they used to be:
/**
* Invoked when a request/response stream is complete, whether successful or unsuccessful
* This is always invoked on the HTTP connection's event-loop thread.
* This will not be invoked if the stream is never activated.
*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.