Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log as warning for socket connect and client bootstrap #594

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Aug 18, 2023

Issue #, if available:

  • Our client bootstrap will try to connect for multiple address resolved by the host resolver. And it may have failure for some address, as long as any one succeed, we established the connection and ignore the error came from other address. Especially, as we do happy eyeball, it will try to use ipv6 and ipv4 at the same time. Most of the case, one of the connection will fail
  • It's very annoy when an error level log shows up, but it's kind expected.

Description of changes:

  • downgrade the level we log the error from socket connect

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.03% ⚠️

Comparison is base (c4b661f) 79.90% compared to head (4ba58c0) 79.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   79.90%   79.88%   -0.03%     
==========================================
  Files          27       27              
  Lines        5848     5846       -2     
==========================================
- Hits         4673     4670       -3     
- Misses       1175     1176       +1     
Files Changed Coverage Δ
source/channel_bootstrap.c 72.44% <50.00%> (-0.27%) ⬇️
source/posix/socket.c 73.91% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TingDaoK TingDaoK marked this pull request as ready for review August 18, 2023 16:23
source/posix/socket.c Show resolved Hide resolved
source/posix/socket.c Outdated Show resolved Hide resolved
source/channel_bootstrap.c Show resolved Hide resolved
source/channel_bootstrap.c Outdated Show resolved Hide resolved
@TingDaoK TingDaoK merged commit e612539 into main Aug 24, 2023
32 checks passed
@TingDaoK TingDaoK deleted the log_warning_for_socket branch August 24, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants