Explicit Private for target_link_libraries (#322)

awslabs · Aug 23, 2023 · 9fc57a1 · 9fc57a1
1 parent cbd9074
commit 9fc57a1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/bin/elastipubsub/CMakeLists.txt b/bin/elastipubsub/CMakeLists.txt
@@ -15,7 +15,7 @@ target_include_directories(${ELASTIPUBSUB_PROJECT_NAME} PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
         $<INSTALL_INTERFACE:include>)
 
-target_link_libraries(${ELASTIPUBSUB_PROJECT_NAME} aws-c-mqtt)
+target_link_libraries(${ELASTIPUBSUB_PROJECT_NAME} PRIVATE aws-c-mqtt)
 
 if (BUILD_SHARED_LIBS AND NOT WIN32)
     message(INFO " elastiPUBSUB will be built with shared libs, but you may need to set LD_LIBRARY_PATH=${CMAKE_INSTALL_PREFIX}/lib to run the application")

diff --git a/bin/elastipubsub5/CMakeLists.txt b/bin/elastipubsub5/CMakeLists.txt
@@ -15,7 +15,7 @@ target_include_directories(${ELASTIPUBSUB_MQTT5_PROJECT_NAME} PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
         $<INSTALL_INTERFACE:include>)
 
-target_link_libraries(${ELASTIPUBSUB_MQTT5_PROJECT_NAME} aws-c-mqtt)
+target_link_libraries(${ELASTIPUBSUB_MQTT5_PROJECT_NAME} PRIVATE aws-c-mqtt)
 
 if (BUILD_SHARED_LIBS AND NOT WIN32)
     message(INFO " elastiPUBSUB will be built with shared libs, but you may need to set LD_LIBRARY_PATH=${CMAKE_INSTALL_PREFIX}/lib to run the application")

diff --git a/bin/mqtt5canary/CMakeLists.txt b/bin/mqtt5canary/CMakeLists.txt
@@ -15,7 +15,7 @@ target_include_directories(${MQTT5CANARY_PROJECT_NAME} PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
         $<INSTALL_INTERFACE:include>)
 
-target_link_libraries(${MQTT5CANARY_PROJECT_NAME} aws-c-mqtt)
+target_link_libraries(${MQTT5CANARY_PROJECT_NAME} PRIVATE aws-c-mqtt)
 
 if (BUILD_SHARED_LIBS AND NOT WIN32)
     message(INFO " mqtt5canary will be built with shared libs, but you may need to set LD_LIBRARY_PATH=${CMAKE_INSTALL_PREFIX}/lib to run the application")