Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMP: Only print packet on error #238

Merged
merged 8 commits into from
Dec 8, 2022
Merged

Conversation

TwistedTwigleg
Copy link
Contributor

Description of changes:

To reduce the amount of data in the console, these adjustments will print the packet data only when an error is discovered. Additionally, all of the logs for printing packet data was moved from DEBUG to ERROR. With these changes, the amount of text in the logs when an error occurs should be a little easier to parse without taking huge amounts of data.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even as a temporary hack I don't think we should be doing this.

I'd much rather just change the meaning of the basic setting to only log on error and save off the decode packet cursor before decode and log that on error.

@TwistedTwigleg
Copy link
Contributor Author

Thanks! Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit dc3425e into main Dec 8, 2022
@TwistedTwigleg TwistedTwigleg deleted the print_full_packet_on_error branch December 8, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants