Adapter resub stats #305
Closed
Adapter resub stats #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## AdapterSubscribeUnsubscribe #305 +/- ##
===============================================================
- Coverage 82.18% 82.09% -0.10%
===============================================================
Files 19 19
Lines 8376 8445 +69
===============================================================
+ Hits 6884 6933 +49
- Misses 1492 1512 +20
☔ View full report in Codecov by Sentry. |
sbSteveK
reviewed
Jul 14, 2023
sbSteveK
reviewed
Jul 14, 2023
| * If we're a regular subscribe, build the mqtt5 operation now. Otherwise, we have to wait until | ||
| * we're on the event loop thread and it's safe to query the subscription set. | ||
| */ | ||
| if (options->subscription_count > 0) { |
There was a problem hiding this comment.
If it's possible to call aws_mqtt_client_connection_subscribe_multiple with an empty aws_array_list, the subscription_count would be zero, the subscribe_op->subscribe_op would remain null, and the subscribe multiple might trigger a resubscribe.
There was a problem hiding this comment.
True, will add a synchronous failure check for that case.
sbSteveK
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.