Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter connection result callbacks #306

Closed
wants to merge 3 commits into from

Conversation

bretambrose
Copy link
Contributor

  • Adapter support for connection success and connection failure callbacks
  • Update existing lifecycle tests to check new callbacks
  • Add reconnect failure test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 94.44% and project coverage change: +0.16 🎉

Comparison is base (34d265b) 82.04% compared to head (6e5e08b) 82.20%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           AdapterResubStats     #306      +/-   ##
=====================================================
+ Coverage              82.04%   82.20%   +0.16%     
=====================================================
  Files                     19       19              
  Lines                   8448     8485      +37     
=====================================================
+ Hits                    6931     6975      +44     
+ Misses                  1517     1510       -7     
Impacted Files Coverage Δ
source/v5/mqtt3_to_mqtt5_adapter.c 79.34% <94.44%> (+0.75%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bretambrose bretambrose marked this pull request as ready for review July 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants