Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter error translation #307

Closed
wants to merge 3 commits into from

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Jul 14, 2023

  • Adds best effort translation from mqtt5 to mqtt311 error codes. This makes it much more likely that changing from the 3 client to the 5 client via the adapter does not confuse users with new error codes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 81.60% and project coverage change: -0.07 ⚠️

Comparison is base (34d265b) 82.04% compared to head (2e366c1) 81.97%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           AdapterResubStats     #307      +/-   ##
=====================================================
- Coverage              82.04%   81.97%   -0.07%     
=====================================================
  Files                     19       19              
  Lines                   8448     8518      +70     
=====================================================
+ Hits                    6931     6983      +52     
- Misses                  1517     1535      +18     
Impacted Files Coverage Δ
source/v5/mqtt3_to_mqtt5_adapter.c 78.31% <81.60%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bretambrose bretambrose marked this pull request as ready for review July 26, 2023 16:42
@bretambrose bretambrose changed the base branch from AdapterResubStats to AdapterConnectionResult July 26, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants