Adapter final polish #308
Closed
Adapter final polish #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Looks good. The focus on logging in this PR was the impetus for wondering about adding an mqtt adapter specific log subject. A lot of these logs feel on the fence and could fall on either side of making more sense as a LS mqtt client or mqtt adapter. It'd be fine to just keep it as is. Your call!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some more logging to the adapter implementation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.