Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run forgotten content type tests #309

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Run forgotten content type tests #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e4501
Run forgotten content type tests
Jul 17, 2023
f2d968f
Clean up some mess I noticed
bretambrose Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ add_test_case(mqtt5_operation_publish_validation_failure_response_topic_too_long
add_test_case(mqtt5_operation_publish_validation_failure_invalid_response_topic)
add_test_case(mqtt5_operation_publish_validation_failure_invalid_utf8_response_topic)
add_test_case(mqtt5_operation_publish_validation_failure_correlation_data_too_long)
add_test_case(mqtt5_operation_publish_validation_failure_content_type_too_long)
add_test_case(mqtt5_operation_publish_validation_failure_invalid_utf8_content_type)
add_test_case(mqtt5_operation_publish_validation_failure_subscription_identifier_exists)
add_test_case(mqtt5_operation_publish_validation_failure_topic_alias_zero)
add_test_case(mqtt5_operation_publish_validation_failure_user_properties_name_too_long)
Expand Down
9 changes: 0 additions & 9 deletions tests/v5/mqtt5_encoding_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@

#include <aws/testing/aws_test_harness.h>

/*
* AWS_MQTT_API enum aws_mqtt5_decode_result_type aws_mqtt5_decode_vli(struct aws_byte_cursor *cursor, uint32_t *dest);
* AWS_MQTT_API int aws_mqtt5_encode_variable_length_integer(struct aws_byte_buf *buf, uint32_t value);
* AWS_MQTT_API int aws_mqtt5_get_variable_length_encode_size(size_t value, size_t *encode_size);
*/

static int s_mqtt5_vli_size_fn(struct aws_allocator *allocator, void *ctx) {
(void)ctx;
(void)allocator;
Expand Down Expand Up @@ -47,9 +41,6 @@ static int s_mqtt5_vli_size_fn(struct aws_allocator *allocator, void *ctx) {
ASSERT_SUCCESS(aws_mqtt5_get_variable_length_encode_size(16384, &encode_size));
ASSERT_INT_EQUALS(3, encode_size);

ASSERT_SUCCESS(aws_mqtt5_get_variable_length_encode_size(16384, &encode_size));
ASSERT_INT_EQUALS(3, encode_size);

ASSERT_SUCCESS(aws_mqtt5_get_variable_length_encode_size(16385, &encode_size));
ASSERT_INT_EQUALS(3, encode_size);

Expand Down