Address theoretical possibility of a TPS-throttled publish getting lost #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
changed the title
xiazhvera
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If extended flow control was on, there was a very small chance (based on timing) that a throttled publish could be dropped entirely by the client. At first it seemed like it should be happening all the time, but a close reading of the implementation shows why it didn't: the queue processing loop would check the next schedule time at the bottom and skip out when it was about to get throttled. Similarly, the next service time would honor throttling calculations, so the only way to lose the operation was to be slightly off by a matter of nanoseconds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.