Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol adapter skeleton #342

Closed
wants to merge 21 commits into from
Closed

Protocol adapter skeleton #342

wants to merge 21 commits into from

Conversation

bretambrose
Copy link
Contributor

  • Request-response protocol adapter interface
  • MQTT5 specific implementation of the request-response protocol adapter interface

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (171840f) 82.54% compared to head (38532f0) 82.55%.

Files Patch % Lines
source/request-response/protocol_adapter.c 84.07% 25 Missing ⚠️
source/client.c 0.00% 3 Missing ⚠️
source/v5/mqtt5_to_mqtt3_adapter.c 0.00% 3 Missing ⚠️
source/client_impl_shared.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   82.54%   82.55%   +0.01%     
==========================================
  Files          20       22       +2     
  Lines        8763     8949     +186     
==========================================
+ Hits         7233     7388     +155     
- Misses       1530     1561      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbSteveK
Copy link
Contributor

We might want to update mqtt5_client.h "@param completion_options" to include a short description of the recently added ack_timeout_seconds_override members since the options aren't really addressed anywhere else. We could also include somewhere in the code comments or some documentation around the request-response various option structs what's up with the ack_timeout_seconds each has and what its default value does. Mostly for ourselves in case we're looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants