push ping time only if the request complete is successful

[alfred2g]

push ping time only if the request complete is successful

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31bce8a) 82.53% compared to head (628c23e) 82.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   82.53%   82.61%   +0.07%     
==========================================
  Files          20       20              
  Lines        8764     8764              
==========================================
+ Hits         7233     7240       +7     
+ Misses       1531     1524       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bretambrose]

Ahhhh, timeouts.

We should add a test variant that sets operation timeouts, no acks, and verifies we eventually send a ping as expected. See test_mqtt_connection_ping_no for a starting point.

[bretambrose]

Fix n ship