Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled keep alive #363

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Disabled keep alive #363

merged 3 commits into from
Mar 26, 2024

Conversation

bretambrose
Copy link
Contributor

  • Disable pings entirely if the final negotiated keep alive value is zero.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (1efb8f9) to head (98d4f3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   82.61%   82.62%           
=======================================
  Files          20       20           
  Lines        8756     8758    +2     
=======================================
+ Hits         7234     7236    +2     
  Misses       1522     1522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bretambrose bretambrose merged commit ed7bbd6 into main Mar 26, 2024
31 checks passed
@bretambrose bretambrose deleted the DisabledKeepAlive branch March 26, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants