ifndef BYO_CRYPTO #144
Merged
ifndef BYO_CRYPTO #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinboswell
suggested changes
Jul 19, 2021
TingDaoK
requested changes
Jul 19, 2021
|
commit is necessary due to BYO_CRYPTO builds failing in aws-crt-cpp
|
TingDaoK
reviewed
Jul 19, 2021
source/s3_client.c
Outdated
| /* If the initial request already has partNumber, the request is not splittable(?). Treat it as a Default | ||
| * request. | ||
| * TODO: Still need tests to verify that the request of a part is splittable or not */ | ||
| if (aws_http_headers_has(initial_message_headers, aws_byte_cursor_from_c_str("partNumber"))) { |
There was a problem hiding this comment.
why delete this part? And have you tried to use this branch for aws-crt-cpp and see the CI is happy or not?
There was a problem hiding this comment.
mistake, fixed with new commit.
There was a problem hiding this comment.
BYO_CRYPTO works on crt-cpp with s3 on this branch.
https://github.com/awslabs/aws-crt-cpp/runs/3107882821?check_suite_focus=true
TingDaoK
reviewed
Jul 19, 2021
TingDaoK
approved these changes
Jul 20, 2021
justinboswell
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.