Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default throughput monitoring #265

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Mar 10, 2023

The last PR didn't actually work: #263
That's what happens when you don't add tests

Thank you @zoewangg for pointing out minimum bytes should be 1, not 0.
Thank you @TingDaoK for the awesome mock server that let us emulate crazy server behavior.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #265 (6662a80) into main (9566422) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   87.17%   87.06%   -0.11%     
==========================================
  Files          16       16              
  Lines        4046     4036      -10     
==========================================
- Hits         3527     3514      -13     
- Misses        519      522       +3     
Impacted Files Coverage Δ
source/s3_client.c 86.65% <100.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

@graebm graebm merged commit c054a32 into main Mar 10, 2023
@graebm graebm deleted the fix-default-throughput-monitoring branch March 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants