Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto - Update S3 Ruleset & Partition #408

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Mar 13, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 enabled auto-merge (squash) March 14, 2024 22:38
@waahm7 waahm7 disabled auto-merge March 15, 2024 17:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (59569e3) to head (5c8be46).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   89.37%   89.35%   -0.02%     
==========================================
  Files          20       20              
  Lines        5854     5854              
==========================================
- Hits         5232     5231       -1     
- Misses        622      623       +1     

see 1 file with indirect coverage changes

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not merge the workaround with this PR?
I would like we can revert those workaround once the github action releases the fix next Friday.

@waahm7
Copy link
Contributor Author

waahm7 commented Mar 15, 2024

can we not merge the workaround with this PR? I would like we can revert those workaround once the github action releases the fix next Friday.

I am not going to merge the workaround with this PR. I am just testing if the CI works.

@waahm7 waahm7 enabled auto-merge (squash) March 15, 2024 22:31
@waahm7 waahm7 merged commit 741674c into main Mar 15, 2024
30 checks passed
@waahm7 waahm7 deleted the update-ruleset-8ebc8730-7b97-486f-bf80-e6febe0ff7e2 branch March 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants