Small buffer #422
Merged
Small buffer #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
reviewed
Mar 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 20 20
Lines 5868 5872 +4
=======================================
+ Hits 5246 5250 +4
Misses 622 622
|
waahm7
approved these changes
Mar 29, 2024
graebm
approved these changes
Mar 29, 2024
Co-authored-by: Michael Graeb <graebm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
fix large s3 errors not being processed correctly and returning weird buffer too small error instead.
fixes issues like aws/aws-sdk-cpp#2892
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.