-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shutdown_callback or returning NULL contract for meta_request #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
WIP | shutdown callback fix
Fix shutdown_callback or returning NULL contract for meta_request
Jun 18, 2024
graebm
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, but had questions
Co-authored-by: Michael Graeb <graebm@amazon.com>
graebm
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-java-v2#5277
Description of changes:
There are multiple places where a meta-request can fail after doing the aws_s3_meta_request_init_base like
aws-c-s3/source/s3_auto_ranged_get.c
Line 98 in 9639492
aws-c-s3/source/s3_client.c
Line 994 in 9639492
aws-c-s3/source/s3_client.c
Line 1055 in 9639492
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.