support if-none-match for upload #462
Merged
+105
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
- Coverage 89.63% 89.62% -0.02%
==========================================
Files 20 20
Lines 6137 6137
==========================================
- Hits 5501 5500 -1
- Misses 636 637 +1
|
graebm
approved these changes
Nov 22, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
8
to
10
| # Allow one instance of this workflow per pull request, and cancel older runs when new changes are pushed | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} |
There was a problem hiding this comment.
trivial: this is slightly different than what we have in aws-crt-java and aws-crt-cpp, which do this:
group: ${{ github.workflow }}-${{ github.ref }}
which I got from these docs:
https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs
tests/s3_data_plane_tests.c
Outdated
Comment on lines
3057
to
3058
| .object_path_override = g_pre_existing_object_10MB, | ||
| .object_size_mb = 5, |
There was a problem hiding this comment.
trivial: it's weird to use the _10MB and then upload 5MB
Suggested change
| .object_path_override = g_pre_existing_object_10MB, | |
| .object_size_mb = 5, | |
| .object_path_override = g_pre_existing_object_1MB, | |
| .object_size_mb = 1, |
tests/s3_data_plane_tests.c
Outdated
Comment on lines
3083
to
3084
| .object_path_override = g_pre_existing_object_10MB, | ||
| .object_size_mb = 20, |
There was a problem hiding this comment.
trivial: same
Suggested change
| .object_path_override = g_pre_existing_object_10MB, | |
| .object_size_mb = 20, | |
| .object_path_override = g_pre_existing_object_10MB, | |
| .object_size_mb = 10, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
if-none-matchfor single part and multipart upload.if-none-matchincluded for every sub-operation, which should only be the complete MPU operation, which supports it.Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.