Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML output doesn't quote string literals eagerly enough #1100

Closed
RomainMuller opened this issue Nov 7, 2018 · 0 comments · Fixed by #1105 or #1118
Closed

YAML output doesn't quote string literals eagerly enough #1100

RomainMuller opened this issue Nov 7, 2018 · 0 comments · Fixed by #1105 or #1118
Labels
bug This issue is a bug.

Comments

@RomainMuller
Copy link
Contributor

When creating a @aws-cdk/aws-lambda.Permission, the #principal attribute can be set to the account ID of a trusted account, passed as a string literal. The current YAML serializer of the CDK encodes account IDs such as 012345678912 without quoting, and consequently a YAML parser may interpret this sequence as a number. When this happens, the leading zero(es) are dropped and the account ID is no longer valid.
@RomainMuller RomainMuller added the bug This issue is a bug. label Nov 7, 2018
rix0rrr pushed a commit that referenced this issue Nov 7, 2018
fix: correctly emit quoted YAML for account numbers
28232ff 
Switch back to the newly-fixed 'yaml' package so that we can get
both correct quoting of strings with leading '0' characters and
correct quoting of strings with colon ':' characters.

Fixes #1100, fixes #1098.
@rix0rrr rix0rrr mentioned this issue Nov 7, 2018
Merged
rix0rrr added a commit that referenced this issue Nov 8, 2018
@rix0rrr
fix: correctly emit quoted YAML for account numbers (#1105)
b4d9155 
Switch back to the newly-fixed 'yaml' package so that we can get
both correct quoting of strings with leading '0' characters and
correct quoting of strings with colon ':' characters.

Fixes #1100, fixes #1098.
rix0rrr pushed a commit that referenced this issue Nov 8, 2018
v0.15.2
1ce5f27 
Bug Fixes
==========

* correctly emit quoted YAML for account numbers ([#1105](#1105)) ([b4d9155](b4d9155)), closes [#1100](#1100) [#1098](#1098)
* **aws-ecs:** fix use of published NPM package with TypeScript ([#1117](#1117)) ([ebfb522](ebfb522))

Features
==========

* **aws-ecs:** Add desired count to LoadBalanced[Fargate|EC2]Service ([#1111](#1111)) ([cafcc11](cafcc11))
@rix0rrr rix0rrr mentioned this issue Nov 8, 2018
Merged
rix0rrr added a commit that referenced this issue Nov 8, 2018
@rix0rrr
v0.15.2 (#1118)
570bd9f 
Bug Fixes
==========

* correctly emit quoted YAML for account numbers ([#1105](#1105)) ([b4d9155](b4d9155)), closes [#1100](#1100) [#1098](#1098)
* **aws-ecs:** fix use of published NPM package with TypeScript ([#1117](#1117)) ([ebfb522](ebfb522))

Features
==========

* **aws-ecs:** Add desired count to LoadBalanced[Fargate|EC2]Service ([#1111](#1111)) ([cafcc11](cafcc11))
@eladb eladb mentioned this issue Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly emit quoted YAML for account numbers aws/aws-cdk
v0.15.2 aws/aws-cdk
1 participant
@RomainMuller