Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdk init: rename "dotnet" to "csharp" #1123

Closed
eladb opened this issue Nov 8, 2018 · 7 comments · Fixed by #1210
Closed

cdk init: rename "dotnet" to "csharp" #1123

eladb opened this issue Nov 8, 2018 · 7 comments · Fixed by #1210
Labels
ui Related to CLI User Interface issues

Comments

@eladb
Copy link
Contributor

eladb commented Nov 8, 2018

Because it's a C# project

@eladb eladb added the ui Related to CLI User Interface issues label Nov 13, 2018
@Niladri24dutta
Copy link

Niladri24dutta commented Nov 14, 2018

@eladb Can I work on this ? it seems only this below directory needs to be changed for this https://github.com/awslabs/aws-cdk/tree/master/packages/aws-cdk/lib/init-templates/app/dotnet to https://github.com/awslabs/aws-cdk/tree/master/packages/aws-cdk/lib/init-templates/app/csharp and the corresponding change should be updated in the documentation for language argument of command line params . Please let me know if my understanding is correct .
I think below line looks for the existing template languages based on the directory name
https://github.com/awslabs/aws-cdk/blob/master/packages/aws-cdk/bin/cdk.ts#L38

@eladb
Copy link
Contributor Author

eladb commented Nov 14, 2018

Thanks so much for proposing. And you are correct in your approach. Technically this is all that needs to be changed in the CDK repo, but we have a bunch of integration tests for "cdk init" in another repo that also must be updated.

Perhaps what we can do is copy & paste the "dotnet" directory into "csharp" so the change will be backwards compatible and then we can update our integration tests and deprecate "dotnet".

@Niladri24dutta
Copy link

Niladri24dutta commented Nov 14, 2018

@eladb that would be a good idea. I Can start making the changes in my branch if it's fine with you. Can you provide the integration test repo url so that I can update them?

@eladb
Copy link
Contributor Author

eladb commented Nov 14, 2018

Go ahead, much appreciated

@Niladri24dutta
Copy link

@eladb Can you please let me know the location for the integration tests ?

@eladb
Copy link
Contributor Author

eladb commented Nov 19, 2018

Our integration tests are mastered in a private repo. Let's just start with duplicating "dotnet" to "csharp" and we'll take it from there.

@Niladri24dutta
Copy link

@eladb got it ... I will create the PR for this

rix0rrr added a commit that referenced this issue Nov 19, 2018
The 'dotnet' template should more properly be called 'csharp', since
that's the actual name of the language in which it is written.

Fixes #1123.
rix0rrr added a commit that referenced this issue Nov 20, 2018
The 'dotnet' template should more properly be called 'csharp', since
that's the actual name of the language in which it is written.

Fixes #1123.
rix0rrr added a commit that referenced this issue Nov 21, 2018
The 'dotnet' template should more properly be called 'csharp', since
that's the actual name of the language in which it is written.

Fixes #1123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to CLI User Interface issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants