Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-codepipeline, aws-cloudformation): support cross-region Pipelines for CFN Actions #1152

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

skinny85
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from eladb November 13, 2018 00:32
packages/@aws-cdk/aws-codepipeline/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved
…ion CodePipeline feature in CloudFormation Pipeline Actions.
@skinny85 skinny85 force-pushed the feature/cross-region-codepipelines branch from d84f970 to 13f2326 Compare November 13, 2018 22:19
@skinny85
Copy link
Contributor Author

Updated with Elad's comments.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 Looks good for today's release.

Please follow up all unresolved conversations in a subsequent PR (or a discussion 😉)

@eladb eladb merged commit 8e701ad into aws:master Nov 14, 2018
@skinny85
Copy link
Contributor Author

Thanks @eladb!

@skinny85 skinny85 deleted the feature/cross-region-codepipelines branch December 11, 2018 01:10
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants