Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ecs): Added dockerVolumeConfiguration to Volume #1357

Merged
merged 7 commits into from
Jan 15, 2019

Conversation

cohalz
Copy link
Contributor

@cohalz cohalz commented Dec 13, 2018

Fixes #1356


Pull Request Checklist

Please check all boxes, including N/A items:

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration tests manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@cohalz cohalz requested a review from a team as a code owner December 13, 2018 15:36
@cohalz cohalz changed the title feat(aws-ecs): Added dockerVolumeConfiguration for Volume feat(aws-ecs): Added dockerVolumeConfiguration to Volume Dec 13, 2018
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let @rix0rrr and/or @clareliguori to chime in

packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts Outdated Show resolved Hide resolved
@clareliguori
Copy link
Member

cc @SoManyHs

@cohalz
Copy link
Contributor Author

cohalz commented Dec 14, 2018

fixed the pointed out part

/**
* Specifies this configuration when using Docker volumes
*/
dockerVolumeConfiguration?: DockerVolumeConfiguration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to have these inline in the Volume struct.

As well as, why are the name and the configuration optional? Does it make sense to leave them optional?

I know @SoManyHs was working on a higher-level abstraction over volumes, so I'd like her to weigh in as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will out of the office until the new year, but will try to take a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DockerVolumeConfiguration support
5 participants