Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudFormation CodePipeline Actions should accept IRole instead of Role #1361

Closed
skinny85 opened this issue Dec 13, 2018 · 0 comments · Fixed by #1364
Closed

CloudFormation CodePipeline Actions should accept IRole instead of Role #1361

skinny85 opened this issue Dec 13, 2018 · 0 comments · Fixed by #1364
Assignees
@skinny85
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline good first issue Related to contributions. See CONTRIBUTING.md

Comments

@skinny85
Copy link
Contributor

Accepting Role means we can't use it with imported Roles.

Reported by @rhboyd on our Gitter channel.
@skinny85 skinny85 self-assigned this Dec 13, 2018
@skinny85 skinny85 added good first issue Related to contributions. See CONTRIBUTING.md @aws-cdk/aws-codepipeline Related to AWS CodePipeline labels Dec 13, 2018
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Dec 14, 2018
@skinny85
fix(aws-cloudformation): change the type of Role in CodePipeline Acti…
90b5295 
…ons to IRole.

BREAKING CHANGE: this changes the type of the `role` property in CFN CodePipeline Actions
from `Role` to `IRole`.

This is needed to use imported Roles when creating Actions.

Fixes aws#1361
@skinny85 skinny85 mentioned this issue Dec 14, 2018
Merged
9 tasks
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Dec 17, 2018
@skinny85
fix(aws-cloudformation): change the type of Role in CodePipeline Acti…
e825527 
…ons to IRole.

BREAKING CHANGE: this changes the type of the `role` property in CFN CodePipeline Actions
from `Role` to `IRole`.

This is needed to use imported Roles when creating Actions.

Fixes aws#1361
skinny85 added a commit that referenced this issue Dec 18, 2018
@skinny85
fix(aws-cloudformation): change the type of Role in CodePipeline Acti…
3d07e48 
…ons to IRole. (#1364)

BREAKING CHANGE: this changes the type of the `role` property in CFN CodePipeline Actions
from `Role` to `IRole`.

This is needed to use imported Roles when creating Actions.

Fixes #1361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-cloudformation): change use of Role to IRole in CodePipeline Actions skinny85/aws-cdk
1 participant
@skinny85