fix(aws-cloudformation): change use of Role to IRole in CodePipeline Actions #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
changed the title
RomainMuller
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Looks good to me, but I'm not sure this counts as a Breaking change, since Role implements IRole.
@eladb what do you think?
|
I've added the necessary (hopefully sufficient) fix to |
|
Thanks for taking this one over @RomainMuller! |
|
I think it's still a breaking change, as |
eladb
approved these changes
Dec 16, 2018
| @@ -51,7 +51,7 @@ export interface PipelineDeployStackActionProps { | |||
| * | |||
| * @default A fresh role with admin or no permissions (depending on the value of `adminPermissions`). | |||
| */ | |||
| role?: iam.Role; | |||
| role?: iam.IRole; | |||
There was a problem hiding this comment.
The change in props is not a breaking change (code that passed Role here would still work)
| @@ -97,7 +97,7 @@ export class PipelineDeployStackAction extends cdk.Construct { | |||
| /** | |||
| * The role used by CloudFormation for the deploy action | |||
| */ | |||
| public readonly role: iam.Role; | |||
| public readonly role: iam.IRole; | |||
There was a problem hiding this comment.
This is a breaking change (code that expects to find Role here now finds something more abstract).
packages/@aws-cdk/app-delivery/test/test.pipeline-deploy-stack-action.ts
Outdated
Show resolved
Hide resolved
…ons to IRole. BREAKING CHANGE: this changes the type of the `role` property in CFN CodePipeline Actions from `Role` to `IRole`. This is needed to use imported Roles when creating Actions. Fixes aws#1361
skinny85
force-pushed
the
feature/irole-in-cfn-actions
branch
from
0c6e2f3 to
e825527
Compare
|
Changed the test according to @eladb's suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: this changes the type of the
roleproperty in CFN CodePipeline Actionsfrom
RoletoIRole.This is needed to use imported Roles when creating Actions.
Fixes #1361
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.