-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): misc cleanups to App-related APIs #2731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure documentation coverage and clean up of the various APIs. Fixes #1891 BREAKING CHANGE: * **core:** `StackProps.autoDeploy` has been removed and replaced by `StackProps.hide` (with negated logic). * **core:** `ISynthesizable.synthesize` now accepts an `ISynthesisSession` which contains the `CloudAssemblyBuilder` object. * **cx-api:** Multiple changes to the cloud assembly APIs to reduce surface area and clean up.
eladb
changed the title
refactor(core): Misc cleanups to App-related APIs
refactor(core): misc cleanups to App-related APIs
Jun 3, 2019
RomainMuller
suggested changes
Jun 4, 2019
rix0rrr
reviewed
Jun 4, 2019
BREAKING CHANGE: - `StackProps.autoDeploy` renamed to `entrypoint` (still true by default). - CLI must be upgraded to 0.34.0 (cx protocol changes)
rix0rrr
reviewed
Jun 4, 2019
RomainMuller
reviewed
Jun 4, 2019
rix0rrr
approved these changes
Jun 5, 2019
RomainMuller
approved these changes
Jun 5, 2019
rix0rrr
reviewed
Jun 5, 2019
...ges/@aws-cdk/aws-codepipeline-actions/test/integ.lambda-deployed-through-codepipeline.lit.ts
Outdated
Show resolved
Hide resolved
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1891
Testing: all toolkit integration tests passed.
BREAKING CHANGE:
App.run()
was renamed toApp.synth()
(soft deprecation, it will be removed in the next release).Stack.autoDeploy
feature has been removed. You can usecdk deploy STACK ...
to determine which stacks to deploy (and wildcards are supported, socdk deploy '*'
will deploy all stacks. We plan to change the CLI to require specifying stacks if there is more than a single stack in the app (cdk deploy: require argument if there is more than a single stack #2750).ConstructNode.aspects
is now private.Synthesizer
has been removed. UseConstructNode.synth(node)
instead.ISynthesizable.synthesize
now accepts anISynthesisSession
which contains theCloudAssemblyBuilder
object. This will allow further extension in the future.cxapi.MissingContext
now includes the contextkey
Stack.reportMissingContext
now accepts a single argument of typecxapi.MissingContext
, which includes the missing context keyStack.annotatePhysicalName
has been removed (not used).Stack.missingContext
is now private./// !cdk-integ STACK ...
to explicitly specify which stacks to include in the test.app.run()
toapp.synth()
. I think it will make it more clear that this is basically what "cdk synth" is invoking. Renamed!Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.