Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update all enum members to be UPPER_CASE #2918

Merged
merged 43 commits into from
Jun 20, 2019

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Jun 19, 2019

Updating all enum members to be UPPER_CASE.
This is in accordance with the new construct library guidelines.

Fixes #2287

BREAKING CHANGE:

  • all enum members were changed from PascalCase to TRUMP_CASE

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

shivlaks added 30 commits June 17, 2019 12:09
benmunro added a commit to benmunro/aws-cdk that referenced this pull request Jul 5, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed
benmunro added a commit to benmunro/aws-cdk that referenced this pull request Jul 5, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed
mergify bot pushed a commit that referenced this pull request Jul 6, 2021
The Effect enum values were changed to be upper case in #2918 (b735d1c) but this usage in the docs was missed


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
upparekh pushed a commit to upparekh/aws-cdk that referenced this pull request Jul 8, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert all enums to UPPER_CASE (jsii?)
3 participants