[BREAKING] Rename @aws-cdk/ec2.Fleet to AutoScalingGroup
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are already several overloads in the AWS landscape for the word `Fleet`, namely `Spot Fleet`, `EC2 Fleet`, ... We should avoid creating new overloads for the term. Instead, use the "standard" EC2 semantics of `AutoScalingGroup`. Fixes #313
eladb
approved these changes
Jul 11, 2018
| @@ -1,6 +1,6 @@ | |||
| import { App, Stack, StackProps } from '@aws-cdk/core'; | |||
| import { | |||
| AmazonLinuxImage, ClassicLoadBalancer, Fleet, InstanceClass, InstanceSize, | |||
| AmazonLinuxImage, AutoScalingGroup, ClassicLoadBalancer, InstanceClass, InstanceSize, | |||
| @@ -4,7 +4,7 @@ | |||
| // ordering stack deployments. So run this test by hand for now | |||
| // until we have that. | |||
| import { App, Stack } from '@aws-cdk/core'; | |||
| import { AmazonLinuxImage, AnyIPv4, ClassicLoadBalancer, Fleet, InstanceClass, InstanceSize, | |||
| import { AmazonLinuxImage, AnyIPv4, AutoScalingGroup, ClassicLoadBalancer, InstanceClass, InstanceSize, | |||
eladb
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are already several overloads in the AWS landscape for the word
Fleet,namely
Spot Fleet,EC2 Fleet, ... We should avoid creating new overloads forthe term. Instead, use the "standard" EC2 semantics of
AutoScalingGroup.Fixes #313