Correct java examples #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Aug 3, 2018
| @@ -6,7 +6,7 @@ const mavenFromNpm = name => ({ | |||
| repo: path.join(path.dirname(require.resolve(name)), 'maven-repo'), | |||
| }); | |||
|
|
|||
| const cdk = mavenFromNpm('aws-cdk-java'); | |||
| const cdk = mavenFromNpm('aws-cdk'); | |||
| const jsii = mavenFromNpm('jsii-java-runtime'); | |||
There was a problem hiding this comment.
I am wondering if it will make more sense to just use the published maven artifacts instead of generate the pom so this is iidiomatic
There was a problem hiding this comment.
That's basically what I'm doing here... Just figuring out the latest version numbers... Honestly this is just what I needed to fix in order to validate the maven staging artifacts... Just wanted those changes not to be lost :)
There was a problem hiding this comment.
We should move those examples to a separate repo so people can clone it and use as a basis for their app.
eladb
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.