DeploymentPreference for SAM Spec #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have the patch files for this, so we don't have to change the files that we get from elsewhere. Can you put this in a patchfile? (Look at others for the format) |
moofish32
force-pushed
the
f-sam-spec-update
branch
from
bb3b548
to
d601221
Compare
moofish32
added a commit
to moofish32/aws-cdk
that referenced
this pull request
Sep 10, 2018
|
This was a just move, now I'll fix the patch syntax. Sorry for the noisy build failure. |
All good :) |
moofish32
force-pushed
the
f-sam-spec-update
branch
from
d601221
to
334f5dc
Compare
moofish32
added a commit
to moofish32/aws-cdk
that referenced
this pull request
Sep 11, 2018
moofish32
force-pushed
the
f-sam-spec-update
branch
from
334f5dc
to
7103062
Compare
moofish32
added a commit
to moofish32/aws-cdk
that referenced
this pull request
Sep 11, 2018
moofish32
force-pushed
the
f-sam-spec-update
branch
from
7103062
to
7b22cac
Compare
|
@rix0rrr -- I think this is right, but I'm not quite sure if there is a test case I should write here? |
eladb
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding DeploymentPreference to SAM spec, I'm not positive I have all the configuration correct.
also: awslabs/goformation#112
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.