Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM Spec DeploymentPreference #112

Closed
wants to merge 4 commits into from

Conversation

moofish32
Copy link

I am attempting to update the SAM Spec so we can include the Deployment Preference section

@PaulMaddox
Copy link
Contributor

Thanks @moofish32 - this project really needs to find a way to automatically update SAM resources, like it does for other CloudFormation ones. In the meantime though, we'll have to keep doing manual updates like this. Thanks for contributing this. 👍

Could you add some tests?

For testing YAML->Go, you can add the fields to test/yaml/aws-serverless-function-2016-10-31.yaml, and then update the with a Serverless function matching 2016-10-31 specification test in goformation_test.go.

For testing Go->YAML, you can add the fields to the with a template that defines an AWS::Serverless::Function test.

Then just run go generate, followed by go test in the project.

@PaulMaddox
Copy link
Contributor

Closing due to inactivity

@PaulMaddox PaulMaddox closed this Oct 23, 2018
@moofish32
Copy link
Author

@PaulMaddox - totally understand the close and I'm sorry I couldn't get back to this. Do you mind if I open an issue? I may have some co-workers able to jump in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants