Start re-factoring the CLI codebase #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
force-pushed
the
rmuller/new-cli
branch
2 times, most recently
from
c09ad3f
to
2684cc4
Compare
rix0rrr
approved these changes
Jun 26, 2018
eladb
reviewed
Jun 27, 2018
| } | ||
|
|
||
| const verifications: Array<() => boolean> = [ | ||
| displayVersionInformation, |
There was a problem hiding this comment.
You might want to make these asynchronous since you will potentially have some file I/O to do
There was a problem hiding this comment.
That makes sense!
| @@ -0,0 +1,60 @@ | |||
| import * as mockery from 'mockery'; | |||
There was a problem hiding this comment.
Add a note that this must be required first
There was a problem hiding this comment.
It can be required whenever... But I guess if you want to use it, you have to not require the stuff you want it to change how they are required before you've configured it... Which feels kind of obvious...
RomainMuller
force-pushed
the
rmuller/new-cli
branch
from
2684cc4
to
00ffaa9
Compare
RomainMuller
added a commit
that referenced
this pull request
Jul 3, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
RomainMuller
force-pushed
the
rmuller/new-cli
branch
from
00ffaa9
to
8db8ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking down the monolithic CLI infrastructure by using
yarg'scommandDirdirective (see #176). This allows modelling each command in a separate module for a cleaner interface.Migrated the
docscommand, and created a prototype of adoctorcommand (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.