This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Removed 2 unnecessary stubbings in CodePipelineJobPollerTest.java #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In our analysis of the project, we observed that
1 stubbing which stubbed
acknowledgeJob
method is created but never executed by 8 testsCodePipelineJobPollerTest.testClassLoad
,CodePipelineJobPollerTest.shouldThrowWhenJobServiceIsNull
,CodePipelineJobPollerTest.shouldThrowWhenJobProcessorIsNull
,CodePipelineJobPollerTest.shouldThrowWhenExecutorServiceIsNull
,CodePipelineJobPollerTest.shouldPollForJobsWhenThereAreNoActiveWorkerThreads
,CodePipelineJobPollerTest.shouldPollForJobsWithBatchSizeWhenNotAllWorkerThreadsAreBusy
,CodePipelineJobPollerTest.shouldStartThreadsForAllReturnedJobs
,CodePipelineJobPollerTest.shouldNotHandOutWorkToJobProcessorWhenStatusFailed
.1 stubbing which stubbed
process
method is created but never executed by 10 testsCodePipelineJobPollerTest.testClassLoad
,CodePipelineJobPollerTest.shouldThrowWhenJobServiceIsNull
,CodePipelineJobPollerTest.shouldThrowWhenJobProcessorIsNull
,CodePipelineJobPollerTest.shouldThrowWhenExecutorServiceIsNull
,CodePipelineJobPollerTest.shouldPollForJobsWhenThereAreNoActiveWorkerThreads
,CodePipelineJobPollerTest.shouldPollForJobsWithBatchSizeWhenNotAllWorkerThreadsAreBusy
,CodePipelineJobPollerTest.shouldStartThreadsForAllReturnedJobs
,CodePipelineJobPollerTest.shouldNotHandOutWorkToJobProcessorWhenStatusFailed
,CodePipelineJobPollerTest.shouldHandleAllRuntimeExceptions
,CodePipelineJobPollerTest.shouldReportFailureWhenProcessorReturnsFailure
.Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.