Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bugfix PR #422

Merged
merged 16 commits into from
May 25, 2023
Merged

Minor Bugfix PR #422

merged 16 commits into from
May 25, 2023

Conversation

bmorrissirromb
Copy link
Collaborator

@bmorrissirromb bmorrissirromb commented Apr 28, 2023

This is a PR to tackle a lot of little minor issues that have been pointed out over the years.

{
  "accountId": "string",
  "arn": "string",
  "availabilityZone": "string",
  "awsRegion": "string",
  "configuration.blockPublicAcls": "boolean",
  "configuration.blockPublicPolicy": "boolean",
  "configuration.ignorePublicAcls": "boolean",
  "configuration.restrictPublicBuckets": "boolean",
  "configurationItemCaptureTime": "string",
  "configurationItemStatus": "string",
  "configurationStateId": "string",
  "relationships.resourceId": "string",
  "relationships.resourceName": "string",
  "relationships.resourceType": "string",
  "resourceCreationTime": "string",
  "resourceId": "string",
  "resourceName": "string",
  "resourceType": "string",
  "tags.key": "string",
  "tags.tag": "string",
  "tags.value": "string",
  "version": "string"
}
{
  "accountId": "string",
  "arn": "string",
  "availabilityZone": "string",
  "awsRegion": "string",
  "configurationItemCaptureTime": "string",
  "configurationItemStatus": "string",
  "configurationStateId": "string",
  "relationships.resourceId": "string",
  "relationships.resourceName": "string",
  "relationships.resourceType": "string",
  "resourceCreationTime": "string",
  "resourceId": "string",
  "resourceName": "string",
  "resourceType": "string",
  "supplementaryConfiguration.instanceStatus": "string",
  "tags.key": "string",
  "tags.tag": "string",
  "tags.value": "string",
  "version": "string"
}

@bmorrissirromb bmorrissirromb marked this pull request as draft April 28, 2023 23:22
@bmorrissirromb bmorrissirromb marked this pull request as ready for review May 24, 2023 22:47
@bmorrissirromb bmorrissirromb changed the title Draft: Minor Bugfix PR Minor Bugfix PR May 25, 2023
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bmorrissirromb bmorrissirromb merged commit 5070410 into master May 25, 2023
@bmorrissirromb bmorrissirromb deleted the little-bugfixes branch July 24, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment