Rubocop #7
Rubocop #7
Conversation
aws-crt/Rakefile
Outdated
| sh "cmake --build #{build_dir}" | ||
| end | ||
| end | ||
|
|
||
| desc 'Move the compiled lib into bin' | ||
| task :bin => :compile do | ||
| task bin: :compile do |
There was a problem hiding this comment.
trivial: I have to say, I liked it better with the arrows
can we ignore that rule in this file?
There was a problem hiding this comment.
This style has been proposed a few times, eg: rubocop/rubocop#1437 and rubocop/rubocop#519 but hasn't really gained support.
I agree I prefer the => (aka hash rocket) for defining tasks as I find it more readable. I'll disable this check for just the Rakefile.
.github/workflows/ci.yml
Outdated
| @@ -15,7 +15,6 @@ env: | |||
| RUN: ${{ github.run_id }}-${{ github.run_number }} | |||
|
|
|||
| jobs: | |||
|
|
|||
There was a problem hiding this comment.
We should add a Github action to run rubocop!
Here's one I found: https://github.com/marketplace/actions/rubocop-linter-action
We could do this in a followup CR
There was a problem hiding this comment.
Agreed - I'd like to add that as a check. There are currently a few rubocop violations that couldn't be auto-corrected. I was waiting for you're refactor to move things around before fixing them + adding a github action.
Description of changes:
Add rubocop with
TargetRubyVersion: 1.9+ gemfile dependency on rubocop 0.50.0 (the last version that supports 1.9). Style relies on default rubocop styles for now.Some minor style fixes from running
rubocop --auto-correctBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.