Skip to content

Commit

Permalink
Add notes about how LaunchTemplate changes are ignored unless you des…
Browse files Browse the repository at this point in the history
…troy the stack and re-create it.
  • Loading branch information
graebm committed Sep 11, 2024
1 parent f5dd91e commit 8db225e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions cdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ If your Batch job is stuck in the RUNNABLE state forever, use the
* Insufficient service quotas for EC2 types (see `check-service-quotas.py`)
* EC2 instance type unavailable (for rare EC2 types)
Changes to the EC2 LaunchTemplate are ignored unless you completely destroy and re-deploy the stack (see [issue](https://github.com/aws/aws-cdk/issues/6686). Metrics data history will survive the apocalypse, so it's no big deal just annoying.

If you need to update to the new latest Amazon Linux, you'll also need to destroy and re-deploy the stack. Otherwise it sticks with the version it was first deployed with.
## Architecture
The requirements driving this architecture are:
Expand Down
3 changes: 2 additions & 1 deletion cdk/s3_benchmarks/s3_benchmarks_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class S3ClientProps:
]

# The "default" set of S3 clients to benchmark.
# For now, only have the Canary test the CRT-based clients.
# Only add clients under active development (e.g. CRT-based),
# since each one adds significantly to execution time.
DEFAULT_S3_CLIENTS = {
'crt-c': S3ClientProps(color=cloudwatch.Color.RED),
'crt-java': S3ClientProps(color=cloudwatch.Color.GREEN),
Expand Down

0 comments on commit 8db225e

Please sign in to comment.