benchmark runner using aws-crt-python or boto3 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
approved these changes
Oct 9, 2023
DmitriyMusatkin
added a commit
that referenced
this pull request
Oct 9, 2023
This reverts commit 50b3119.
Merged
graebm
added a commit
that referenced
this pull request
Oct 18, 2023
Cut down on boilerplate by just having one python runner, instead of separate folders, each with their own build scripts, main functions, and bytes_to_GiB() helper functions, etc, etc, etc This looks like a crap ton of new code, but it's just moving/splitting/combingin code from the following PRs: - #12 - #14 - #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage: benchrunner.py [-h] {crt,boto3} BENCHMARK BUCKET REGION TARGET_THROUGHPUTThis runner will use aws-crt-python OR boto3, depending on the 1st arg.
I like this model of having 1 runner for a given language, with an arg that chooses the library to benchmark (vs my original design of a unique runner for each library). Once this PR is through, I'll merge the CLI runner logic in here too.
Also: flush stdout before running a subprocess, to prevent stuff from printing out of order when you have processes, running processes, running processes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.