Support Rust TransferManager Upload File #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
waahm7
requested review from
aajtodd and
graebm
and removed request for
aajtodd
aajtodd
approved these changes
Aug 14, 2024
| let key = &task_config.key; | ||
|
|
||
| let stream = if self.config().workload.files_on_disk { | ||
| InputStream::from_path(key).with_context(|| "Failed to create stream")? |
There was a problem hiding this comment.
Yes, key and path are supposed to be the same. https://github.com/awslabs/aws-crt-s3-benchmarks/blob/main/workloads/download-30GiB-1x.run.json#L11
graebm
approved these changes
Aug 16, 2024
| let random_data_for_upload: Bytes = { | ||
| let mut rng = fastrand::Rng::new(); | ||
| let data: Vec<u8> = repeat_with(|| rng.u8(..)).take(upload_data_size).collect(); | ||
| data.into() |
There was a problem hiding this comment.
trivial: I know in the C-runner, it's a big noticeable pause when filling a 100GiB buffer with random data. Would this go faster if we asked for random 64bit numbers? Or used a different library?
graebm
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.