Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK: add sdk-java-tm-classic to canary #73

Merged
merged 4 commits into from
Sep 12, 2024
Merged

CDK: add sdk-java-tm-classic to canary #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c90f48
CDK: add sdk-java-tm-classic to canary
graebm Sep 11, 2024
11d005b
lint
graebm Sep 11, 2024
f5dd91e
use yellow instead of light-grey, which was hard to see
graebm Sep 11, 2024
8db225e
Add notes about how LaunchTemplate changes are ignored unless you des…
graebm Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ If your Batch job is stuck in the RUNNABLE state forever, use the
* Insufficient service quotas for EC2 types (see `check-service-quotas.py`)
* EC2 instance type unavailable (for rare EC2 types)

Changes to the EC2 LaunchTemplate are ignored unless you completely destroy and re-deploy the stack (see [issue](https://github.com/aws/aws-cdk/issues/6686). Metrics data history will survive the apocalypse, so it's no big deal just annoying.

If you need to update to the new latest Amazon Linux, you'll also need to destroy and re-deploy the stack. Otherwise it sticks with the version it was first deployed with.

## Architecture

The requirements driving this architecture are:
Expand Down
4 changes: 3 additions & 1 deletion cdk/s3_benchmarks/s3_benchmarks_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ class S3ClientProps:
]

# The "default" set of S3 clients to benchmark.
# For now, only have the Canary test the CRT-based clients.
# Only add clients under active development (e.g. CRT-based),
# since each one adds significantly to execution time.
DEFAULT_S3_CLIENTS = {
'crt-c': S3ClientProps(color=cloudwatch.Color.RED),
'crt-java': S3ClientProps(color=cloudwatch.Color.GREEN),
'sdk-java-client-crt': S3ClientProps(color=cloudwatch.Color.BROWN),
'sdk-java-tm-classic': S3ClientProps(color='#ffd43b'), # yellow
'sdk-java-tm-crt': S3ClientProps(color=cloudwatch.Color.GREY),
'crt-python': S3ClientProps(color=cloudwatch.Color.BLUE),
'cli-crt': S3ClientProps(color=cloudwatch.Color.PURPLE),
Expand Down
Loading