-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust telemetry to JSON files, instead of OTLP/gRPC #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impacting performance
…193320f, just before the crate was modified to NOT do JSON anymore.
… file at the end of each run. Each run gets its spans written to a separate file
Co-authored-by: Waqar Ahmed Khan <waahm7@gmail.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
graebm
changed the title
Rust writes telemetry to JSON file, instead of exporting via OTLP/gRPC
Rust telemetry to JSON files, instead of OTLP/gRPC
Oct 14, 2024
waahm7
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aajtodd
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots going on here, apologies...
opentelemetry-stdout
crate. Specifically, we took the commit just before the Simplify LogExporter::Export interface change. This change removed JSON export, so the code would be simpler for others to copy/paste. But we wanted JSON export, so copy/pasting from that point.flush_to_file(filename)
is called.trace_20241009T185957Z_download-30GiB-1x-ram_run01.json
allspans.py
which graphs ALL tracing spans, each in its own row, similar to tools like Jaegerplotly.express.timeline()
.plotly
was recommended by ChatGPT, I asked for a python graphing library where you could hide information until you mouse-over it. I also specified that files should be easy to share, andplotly
generates a single HTML file.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.