Improve Rust tracing spans #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Oct 18, 2024
waahm7
approved these changes
Oct 18, 2024
| # trim down excessively long strings | ||
| MAX_STRLEN = 150 | ||
| if isinstance(value, str) and len(value) > MAX_STRLEN: | ||
| value = value[:MAX_STRLEN] + "...TRUNCATED" |
There was a problem hiding this comment.
trivial/debatable: ... should be enough.
Suggested change
| value = value[:MAX_STRLEN] + "...TRUNCATED" | |
| value = value[:MAX_STRLEN] + "..." |
There was a problem hiding this comment.
I like it super explicit 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to changes from awslabs/aws-s3-transfer-manager-rs#66
Now that the transfer manager has a lot of nice spans, we can trim some out of here.
Also, some tweaks to the graph.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.