Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adding hash to pipelines processing step function execution names to … #641

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix: Adding hash to pipelines processing step function execution names to … #641

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8989a29
Adding hash to pipelines processing step function execution names to …
avolip Jun 26, 2023
af85438
Adding hash to pipelines processing step function execution names to …
avolip Jun 26, 2023
286e9e1
Apply linting fixes
sbkok Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...ry/adf-bootstrap/deployment/lambda_codebase/pipeline_management/process_deployment_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import json
import tempfile
from typing import Any, TypedDict
import hashlib
import yaml
from yaml.error import YAMLError

Expand Down Expand Up @@ -173,9 +174,12 @@ def start_executions(
# AWS Step Functions supports max 80 characters.
# Since the run_id equals 49 characters plus the dash, we have 30
# characters available. To ensure we don't run over, lets use a
# truncated version instead:
truncated_pipeline_name = full_pipeline_name[:30]
sfn_execution_name = f"{truncated_pipeline_name}-{run_id}"
# truncated version concatenated with an hash generated from
# the pipeline name
truncated_pipeline_name = full_pipeline_name[:24]
name_bytes_to_hash = bytes(full_pipeline_name + run_id, 'utf-8')
execution_unique_hash = hashlib.md5(name_bytes_to_hash).hexdigest()[:5]
sfn_execution_name = f"{truncated_pipeline_name}-{execution_unique_hash}-{run_id}"
sfn_client.start_execution(
stateMachineArn=PIPELINE_MANAGEMENT_STATEMACHINE,
name=sfn_execution_name,
Expand Down