Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fixes #646

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Linter fixes #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f92241d
Fixing cfn-lint and markdown linter
Jul 21, 2023
bd52994
Enable GH status report
Jul 21, 2023
c8ff48c
adding explicit comment permissions
Jul 21, 2023
9b6ad94
Revert "adding explicit comment permissions"
Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .mega-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ SARIF_REPORTER: true
SHOW_ELAPSED_TIME: true
FILEIO_REPORTER: false

# Install pluging for list handling.
# Install plugin for list handling.
JSON_PRETTIER_PRE_COMMANDS:
- command: |
npm install -g prettier-plugin-multiline-arrays@1.1.4
Expand All @@ -44,3 +44,6 @@ SPELL_CSPELL_ARGUMENTS: '--gitignore --no-progress --show-suggestions'
SPELL_CSPELL_FILE_EXTENSIONS: ["*"]
TERRAFORM_TFLINT_UNSECURED_ENV_VARIABLES:
- GITHUB_TOKEN

GITHUB_STATUS_REPORTER: true
GITHUB_COMMENT_REPORTER: true
3 changes: 2 additions & 1 deletion CODE_OF_CONDUCT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ This project has adopted the

For more information see the
[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
opensource-codeofconduct@amazon.com with any additional questions or comments.
[opensource-codeofconduct@amazon.com](mailto:opensource-codeofconduct@amazon.com)
with any additional questions or comments.
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ This project has adopted the
[Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
For more information see the
[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
opensource-codeofconduct@amazon.com with any additional questions or comments.
[opensource-codeofconduct@amazon.com](mailto:opensource-codeofconduct@amazon.com)
with any additional questions or comments.

## Security issue notifications

Expand Down
2 changes: 2 additions & 0 deletions src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ Resources:

KMSKey:
Type: AWS::KMS::Key
DeletionPolicy: Delete
UpdateReplacePolicy: Delete
Properties:
Description: Used by Assumed Roles in Accounts accounts to Encrypt/Decrypt code
EnableKeyRotation: true
Expand Down
2 changes: 2 additions & 0 deletions ...lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/regional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ Resources:

DeploymentFrameworkRegionalKMSKey:
Type: AWS::KMS::Key
DeletionPolicy: Delete
UpdateReplacePolicy: Delete
Properties:
Description: Used by Assumed Roles in Accounts accounts to Encrypt/Decrypt code
EnableKeyRotation: true
Expand Down