chore: update release workflows to use a PAT #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Mar 29, 2024
ashovlin
reviewed
Apr 1, 2024
| # Checkout a full clone of the repo | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: '0' | ||
| token: ${{ env.AWS_SECRET_TOKEN }} |
There was a problem hiding this comment.
Might just be for my understanding, but is this the same as AWS_SECRET on line 37? The names don't match?
There was a problem hiding this comment.
Yes. The github action that fetches the secret from secret manager creates environment variables that have "AWS_SECRET" as a prefix. Since the actual secret is in json format with the key being "token". The resulting environment variable becomes "AWS_SECRET_TOKEN".
ashovlin
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
devtomaindue to our branch protection rules.Note: the 2 repository secrets
RELEASE_WORKFLOW_ACCESS_TOKEN_ROLE_ARNandRELEASE_WORKFLOW_ACCESS_TOKEN_NAMEhave not yet been created. They will be created once we update the release infra.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.